Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(platform): offline banners #197

Open
wants to merge 21 commits into
base: feature/website
Choose a base branch
from
Open

feat(platform): offline banners #197

wants to merge 21 commits into from

Conversation

lennartkloock
Copy link
Member

@lennartkloock lennartkloock commented Jan 18, 2024 •
edited
Loading

Proposed changes

This pr implements offline banners.

Including:

  • New section in profile settings
  • New upload endpoint for offline banners

Types of changes

What types of changes does your code introduce to Scuffle?
Put an x in the boxes that apply

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update (if none of the other choices apply)

Checklist

Put an x in the boxes that apply. You can also fill these out after creating the PR. If you're unsure about any of them, don't hesitate to ask. We're here to help! This is simply a reminder of what we are going to look for before merging your code.

  • I have read the CONTRIBUTING doc
  • Lint and unit tests pass locally with my changes
  • I have added tests that prove my fix is effective or that my feature works
  • I have added necessary documentation (if appropriate)
  • Any dependent changes have been merged and published in downstream modules

Further comments

@codecov Codecov
Copy link

codecov bot commented Jan 18, 2024 •
edited
Loading

Codecov Report

Attention: 306 lines in your changes are missing coverage. Please review.

Comparison is base (d94b57d) 45.48% compared to head (e77c8fb) 45.15%.

Additional details and impacted files 
@@                 Coverage Diff                 @@
##           feature/website     #197      +/-   ##
===================================================
- Coverage            45.48%   45.15%   -0.34%     
===================================================
  Files                  489      491       +2     
  Lines                32133    32369     +236     
===================================================
  Hits                 14617    14617              
- Misses               17516    17752     +236
Files Coverage Δ
platform/api/src/database/channel.rs 0.00% <ø> (ø)
platform/api/src/database/file_type.rs 0.00% <ø> (ø)
platform/api/src/database/role.rs 0.00% <ø> (ø)
platform/api/src/api/v1/gql/mutations/user.rs 0.00% <0.00%> (ø)
platform/api/src/subscription.rs 0.00% <0.00%> (ø)
video/cli/src/invoker/direct.rs 0.00% <0.00%> (ø)
video/ingest/src/ingest/connection.rs 75.41% <50.00%> (ø)
platform/api/src/api/v1/upload/mod.rs 0.00% <0.00%> (ø)
platform/api/src/config.rs 0.00% <0.00%> (ø)
platform/api/src/video_event_handler.rs 0.00% <0.00%> (ø)
... and 8 more

@lennartkloock lennartkloock mentioned this pull request Jan 25, 2024
Draft
9 tasks
@lennartkloock
refactor(platform): image upload
63c8e67
@lennartkloock
feat(platform): add offline banner upload endpoint
d33b7d8
@lennartkloock
feat(platform): handle offline banner callback
b13e763
@lennartkloock
feat(platform): offline banner gql api
e3079af
@lennartkloock
feat(platform): offline banner gql subscription
310b78b
@lennartkloock
feat(website): offline banner support
12e5dd7
@lennartkloock
feat(website): add offline banner setting
0ff7b0e
@lennartkloock
fix(website): offline banner setting
4559dc7
@lennartkloock
fix(webiste): weird background color bug
c28bfd9
@lennartkloock
chore(platform): fmt
2a3e2c7
@lennartkloock
fix(website): responsive image
70ca629
@lennartkloock
fix(platform): offline banner task
be6b33a
@lennartkloock
feat(platform): remove offline banner button
f926410
@lennartkloock
fix(cli): organization get
04b6748
@lennartkloock
fix(platform): image upload callback
383d79c
@lennartkloock
chore: fmt
99db313
@lennartkloock
fix(platform): disable animated offline banners
bea9aa2
@lennartkloock
fix(platform): rebase
02cd582 
I hate merge conflicts
@lennartkloock
chore(platform): fmt
7c811e9
@lennartkloock
fix(website): show no offline banner in settings
7d1a783
@lennartkloock lennartkloock marked this pull request as ready for review January 26, 2024 00:31
@lennartkloock lennartkloock requested review from a team as code owners January 26, 2024 00:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TroyKomodo TroyKomodo TroyKomodo approved these changes

@SputNikPlop SputNikPlop SputNikPlop approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lennartkloock @TroyKomodo @SputNikPlop